From 8e6fca3e624c467a8e2c8aac802579fab55f010b Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Thu, 1 Nov 2018 23:55:48 +0000 Subject: [PATCH 1/9] Fail Azure CI for failing tests --- ci/azure/macos.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/ci/azure/macos.yml b/ci/azure/macos.yml index 53ce51c76683c..17d1c62cde518 100644 --- a/ci/azure/macos.yml +++ b/ci/azure/macos.yml @@ -41,3 +41,28 @@ jobs: inputs: testResultsFiles: 'test-data-*.xml' testRunTitle: 'MacOS-35' + - powershell: | + $junitXml = "test-data-single.xml" + $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-single" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + + $junitXmlMulti = "test-data-multi.xml" + $(Get-Content $junitXmlMulti | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-multi" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + displayName: Check for test failures \ No newline at end of file From 7431f2ea44289255b1c25943e8b759b818870aed Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Fri, 2 Nov 2018 00:02:25 +0000 Subject: [PATCH 2/9] Fail.. --- ci/azure/macos.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/azure/macos.yml b/ci/azure/macos.yml index 17d1c62cde518..ac1135ce71924 100644 --- a/ci/azure/macos.yml +++ b/ci/azure/macos.yml @@ -65,4 +65,3 @@ jobs: # note that this will produce $LASTEXITCODE=1 Write-Error "$($matches[1]) tests failed" } - displayName: Check for test failures \ No newline at end of file From 6a8872bc78aca60dd382be04cfff369542463954 Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Fri, 2 Nov 2018 00:04:36 +0000 Subject: [PATCH 3/9] Add back display name --- ci/azure/macos.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/ci/azure/macos.yml b/ci/azure/macos.yml index ac1135ce71924..349d6962fa4c1 100644 --- a/ci/azure/macos.yml +++ b/ci/azure/macos.yml @@ -65,3 +65,4 @@ jobs: # note that this will produce $LASTEXITCODE=1 Write-Error "$($matches[1]) tests failed" } + displayName: Check for test failures \ No newline at end of file From 0eda2969f1eef78c8a69152239191ed3bf47edc6 Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Sat, 3 Nov 2018 17:18:46 +0000 Subject: [PATCH 4/9] Add checking test failures for windows and linux builds --- ci/azure/linux.yml | 27 ++++++++++++++++++++++++++- ci/azure/macos.yml | 2 +- ci/azure/windows.yml | 25 +++++++++++++++++++++++++ 3 files changed, 52 insertions(+), 2 deletions(-) diff --git a/ci/azure/linux.yml b/ci/azure/linux.yml index f34cba69a6195..120e4419e3096 100644 --- a/ci/azure/linux.yml +++ b/ci/azure/linux.yml @@ -53,4 +53,29 @@ jobs: - task: PublishTestResults@2 inputs: testResultsFiles: 'test-data-*.xml' - testRunTitle: 'Linux' \ No newline at end of file + testRunTitle: 'Linux' + - powershell: | + $junitXml = "test-data-single.xml" + $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-single" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + + $junitXmlMulti = "test-data-multiple.xml" + $(Get-Content $junitXmlMulti | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-multi" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + displayName: Check for test failures \ No newline at end of file diff --git a/ci/azure/macos.yml b/ci/azure/macos.yml index 349d6962fa4c1..ada14a98d5c13 100644 --- a/ci/azure/macos.yml +++ b/ci/azure/macos.yml @@ -54,7 +54,7 @@ jobs: Write-Error "$($matches[1]) tests failed" } - $junitXmlMulti = "test-data-multi.xml" + $junitXmlMulti = "test-data-multiple.xml" $(Get-Content $junitXmlMulti | Out-String) -match 'failures="(.*?)"' if ($matches[1] -eq 0) { diff --git a/ci/azure/windows.yml b/ci/azure/windows.yml index e2e545978e09d..077597247ef64 100644 --- a/ci/azure/windows.yml +++ b/ci/azure/windows.yml @@ -34,3 +34,28 @@ jobs: inputs: testResultsFiles: 'test-data.xml' testRunTitle: 'Windows 36' + - powershell: | + $junitXml = "test-data-single.xml" + $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-single" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + + $junitXmlMulti = "test-data-multiple.xml" + $(Get-Content $junitXmlMulti | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data-multi" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + displayName: Check for test failures \ No newline at end of file From 5eb61121f7527a5821e7efee451d3958d464fa56 Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Sat, 3 Nov 2018 17:43:49 +0000 Subject: [PATCH 5/9] Check failures - to be removed --- pandas/tests/indexing/test_indexing.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index 3b95ba8e4b9d8..7d61087ba7792 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -1103,3 +1103,6 @@ def test_extension_array_cross_section_converts(): result = df.iloc[0] tm.assert_series_equal(result, expected) + +def check_test(): + assert False \ No newline at end of file From e91c84efd7060938fe99d1685ca687393b9b4feb Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Sun, 4 Nov 2018 13:46:15 +0000 Subject: [PATCH 6/9] Add windows 27 and correct junitxml file names --- ci/azure/windows-py27.yml | 13 +++++++++++++ ci/azure/windows.yml | 16 ++-------------- pandas/tests/indexing/test_indexing.py | 5 +++-- 3 files changed, 18 insertions(+), 16 deletions(-) diff --git a/ci/azure/windows-py27.yml b/ci/azure/windows-py27.yml index 991e7adc4e9d6..7cf125301ee90 100644 --- a/ci/azure/windows-py27.yml +++ b/ci/azure/windows-py27.yml @@ -43,3 +43,16 @@ jobs: inputs: testResultsFiles: 'test-data.xml' testRunTitle: 'Windows 27' + - powershell: | + $junitXml = "test-data.xml" + $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"' + if ($matches[1] -eq 0) + { + Write-Host "No test failures in test-data" + } + else + { + # note that this will produce $LASTEXITCODE=1 + Write-Error "$($matches[1]) tests failed" + } + displayName: Check for test failures diff --git a/ci/azure/windows.yml b/ci/azure/windows.yml index 077597247ef64..92412eed0fbe3 100644 --- a/ci/azure/windows.yml +++ b/ci/azure/windows.yml @@ -35,23 +35,11 @@ jobs: testResultsFiles: 'test-data.xml' testRunTitle: 'Windows 36' - powershell: | - $junitXml = "test-data-single.xml" + $junitXml = "test-data.xml" $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"' if ($matches[1] -eq 0) { - Write-Host "No test failures in test-data-single" - } - else - { - # note that this will produce $LASTEXITCODE=1 - Write-Error "$($matches[1]) tests failed" - } - - $junitXmlMulti = "test-data-multiple.xml" - $(Get-Content $junitXmlMulti | Out-String) -match 'failures="(.*?)"' - if ($matches[1] -eq 0) - { - Write-Host "No test failures in test-data-multi" + Write-Host "No test failures in test-data" } else { diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index 7d61087ba7792..f336c49f9f9c1 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -1104,5 +1104,6 @@ def test_extension_array_cross_section_converts(): result = df.iloc[0] tm.assert_series_equal(result, expected) -def check_test(): - assert False \ No newline at end of file + +def test_check(): + assert False From 5ff1874b7d1cadf8c8754889110c2be653cd095f Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Sun, 4 Nov 2018 17:39:03 +0000 Subject: [PATCH 7/9] Set min openpyxl version for MacOS builds --- ci/azure-macos-35.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/azure-macos-35.yaml b/ci/azure-macos-35.yaml index 065deb914dae6..d5684e3e0050b 100644 --- a/ci/azure-macos-35.yaml +++ b/ci/azure-macos-35.yaml @@ -12,7 +12,7 @@ dependencies: - nomkl - numexpr - numpy=1.12.0 - - openpyxl + - openpyxl>=2.5.7 - pytables - python=3.5* - pytz From 767fdae161b4513009a2fee01834276b407a8b89 Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Sun, 4 Nov 2018 21:58:31 +0000 Subject: [PATCH 8/9] Repin openpyxl on macos - 35 --- ci/azure-macos-35.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/azure-macos-35.yaml b/ci/azure-macos-35.yaml index d5684e3e0050b..6ccdc79d11b27 100644 --- a/ci/azure-macos-35.yaml +++ b/ci/azure-macos-35.yaml @@ -12,7 +12,7 @@ dependencies: - nomkl - numexpr - numpy=1.12.0 - - openpyxl>=2.5.7 + - openpyxl=2.5.5 - pytables - python=3.5* - pytz From c1eadc38133bf9447eee7c4d889ae8b67184bea7 Mon Sep 17 00:00:00 2001 From: alimcmaster1 Date: Tue, 6 Nov 2018 19:45:13 +0000 Subject: [PATCH 9/9] Revert dummy test failure --- pandas/tests/indexing/test_indexing.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index f336c49f9f9c1..3b95ba8e4b9d8 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -1103,7 +1103,3 @@ def test_extension_array_cross_section_converts(): result = df.iloc[0] tm.assert_series_equal(result, expected) - - -def test_check(): - assert False