Skip to content

TST: Add interval closed fixture to top-level conftest #21595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

jschendel
Copy link
Member

Noticed identical copies of this fixture in multiple places, so seemed reasonable to dedupe and move to the top-level conftest.py. I think I removed all instances of such a fixture/parametrize being used, but could have missed one. I imagine this fixture will be used in more places in the future when interval related tests are expanded.

@jschendel jschendel added Testing pandas testing functions or related to the test suite Interval Interval data type Clean labels Jun 22, 2018
@jschendel jschendel added this to the 0.24.0 milestone Jun 22, 2018
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #21595 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21595   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49549    49549           
=======================================
  Hits        45539    45539           
  Misses       4010     4010
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028c9c0...c1f84a2. Read the comment docs.

@jreback jreback merged commit a166638 into pandas-dev:master Jun 22, 2018
@jreback
Copy link
Contributor

jreback commented Jun 22, 2018

thanks. its possible this might conflict with 'closed' as used in thinks like pd.date_range and resample which only have left/right but no big deal.

@jschendel jschendel deleted the closed-conftest branch September 24, 2018 17:22
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants