From 6578b2ab9b46f62d9cce028308644f8593720906 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Tue, 5 Jun 2018 21:59:24 +0200 Subject: [PATCH 1/2] DOC: fix mistake in Series.str.cat --- pandas/core/strings.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pandas/core/strings.py b/pandas/core/strings.py index 5d50c45fe7eca..5c410f5656226 100644 --- a/pandas/core/strings.py +++ b/pandas/core/strings.py @@ -2172,9 +2172,9 @@ def cat(self, others=None, sep=None, na_rep=None, join=None): Returns ------- - concat : str if `other is None`, Series/Index of objects if `others is - not None`. In the latter case, the result will remain categorical - if the calling Series/Index is categorical. + concat : + str if `others` is None, Series/Index of objects if `others` is not + None. See Also -------- From 439021ecd31fcdec2b1ccf05d80764bc20a641a3 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Wed, 6 Jun 2018 10:29:10 +0200 Subject: [PATCH 2/2] Incorporate review feedback --- pandas/core/strings.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pandas/core/strings.py b/pandas/core/strings.py index 5c410f5656226..44811781837bc 100644 --- a/pandas/core/strings.py +++ b/pandas/core/strings.py @@ -2172,9 +2172,9 @@ def cat(self, others=None, sep=None, na_rep=None, join=None): Returns ------- - concat : - str if `others` is None, Series/Index of objects if `others` is not - None. + concat : str or Series/Index of objects + If `others` is None, `str` is returned, otherwise a `Series/Index` + (same type as caller) of objects is returned. See Also --------