From 255978dc5bb9c8895047a233483ccd135a8794d4 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Wed, 8 Nov 2017 18:34:04 +0000 Subject: [PATCH 1/4] Clarify default window in rolling() --- pandas/core/window.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/core/window.py b/pandas/core/window.py index 5143dddc5e866..e81076fc87350 100644 --- a/pandas/core/window.py +++ b/pandas/core/window.py @@ -503,6 +503,7 @@ class Window(_Window): * ``general_gaussian`` (needs power, width) * ``slepian`` (needs width). + If ``win_type=None`` a boxcar window is used. """ def validate(self): From d705278fda9d924cae2db210c44ffad51e2db2c5 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Thu, 9 Nov 2017 21:44:35 +0000 Subject: [PATCH 2/4] Add link to scipy window function docs --- pandas/core/window.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pandas/core/window.py b/pandas/core/window.py index e81076fc87350..5a769cddd99ad 100644 --- a/pandas/core/window.py +++ b/pandas/core/window.py @@ -503,7 +503,9 @@ class Window(_Window): * ``general_gaussian`` (needs power, width) * ``slepian`` (needs width). - If ``win_type=None`` a boxcar window is used. + If ``win_type=None`` a boxcar window is used. To learn more about different + window types see `scipy.signal window funcitons + `__. """ def validate(self): From dadec303ba6730065f96e5108997c088cb3a3407 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Thu, 9 Nov 2017 21:50:30 +0000 Subject: [PATCH 3/4] Add scipy windows link to computation.rst --- doc/source/computation.rst | 4 +++- pandas/core/window.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/source/computation.rst b/doc/source/computation.rst index 0325e54d18e36..66ce4f93808ed 100644 --- a/doc/source/computation.rst +++ b/doc/source/computation.rst @@ -344,7 +344,9 @@ The following methods are available: :meth:`~Window.sum`, Sum of values :meth:`~Window.mean`, Mean of values -The weights used in the window are specified by the ``win_type`` keyword. The list of recognized types are: +The weights used in the window are specified by the ``win_type`` keyword. +The list of recognized types are the `scipy.signal window functions + `__: - ``boxcar`` - ``triang`` diff --git a/pandas/core/window.py b/pandas/core/window.py index 5a769cddd99ad..4d553124006cb 100644 --- a/pandas/core/window.py +++ b/pandas/core/window.py @@ -504,7 +504,7 @@ class Window(_Window): * ``slepian`` (needs width). If ``win_type=None`` a boxcar window is used. To learn more about different - window types see `scipy.signal window funcitons + window types see `scipy.signal window functions `__. """ From 70854586c438bef8a9fa1b6958e67c7ddf3d14f4 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Sat, 11 Nov 2017 09:56:56 +0000 Subject: [PATCH 4/4] Clarify wording --- pandas/core/window.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/window.py b/pandas/core/window.py index 4d553124006cb..345f9b035a36b 100644 --- a/pandas/core/window.py +++ b/pandas/core/window.py @@ -503,8 +503,8 @@ class Window(_Window): * ``general_gaussian`` (needs power, width) * ``slepian`` (needs width). - If ``win_type=None`` a boxcar window is used. To learn more about different - window types see `scipy.signal window functions + If ``win_type=None`` all points are evenly weighted. To learn more about + different window types see `scipy.signal window functions `__. """