Skip to content

DOC: Added statsmodels to show_versions #15921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DOC: Added statsmodels to show_versions #15921

wants to merge 1 commit into from

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger added the Dependencies Required and optional dependencies label Apr 6, 2017
@TomAugspurger TomAugspurger added this to the 0.20.0 milestone Apr 6, 2017
@jorisvandenbossche
Copy link
Member

I have nothing against adding statsmodels per se, but the output is getting quite long, so we should maybe restrict it to actual dependencies? AFAIK we don't use statsmodel anywhere in our code? (apart from some doc examples)
Or is it useful when working on statsmodels/pandas compat?

@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #15921 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15921      +/-   ##
==========================================
- Coverage   90.96%   90.95%   -0.01%     
==========================================
  Files         145      145              
  Lines       49534    49534              
==========================================
- Hits        45057    45056       -1     
- Misses       4477     4478       +1
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.63% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/print_versions.py 15.71% <ø> (ø) ⬆️
pandas/tseries/index.py 95.33% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763197c...2336be9. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 6, 2017 •
edited
Loading

Codecov Report

Merging #15921 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15921      +/-   ##
==========================================
- Coverage   90.96%   90.95%   -0.01%     
==========================================
  Files         145      145              
  Lines       49534    49534              
==========================================
- Hits        45057    45056       -1     
- Misses       4477     4478       +1
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.63% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/print_versions.py 15.71% <ø> (ø) ⬆️
pandas/tseries/index.py 95.33% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763197c...2336be9. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Apr 6, 2017

I agree with @jorisvandenbossche here. its not a dependence (any more); we took it out #15353

@jreback jreback changed the title DOC: Added statsmodels to show_versions DOC: Added statsmodels to show_versions Apr 6, 2017
@TomAugspurger
Copy link
Contributor Author

Works for me.

@TomAugspurger TomAugspurger deleted the statsmodels-version branch May 29, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jorisvandenbossche @jreback