From 40e6e06c258013e5ccfabfade77895696ee4b4d0 Mon Sep 17 00:00:00 2001 From: gfyoung Date: Mon, 19 Dec 2016 11:11:43 -0500 Subject: [PATCH 1/2] MAINT: Only output errors in C style check --- ci/lint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/lint.sh b/ci/lint.sh index d7df6215450b4..4ef1141de8c4c 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -49,7 +49,7 @@ if [ "$LINT" ]; then for path in '*.h' 'period_helper.c' 'datetime' 'parser' 'ujson' do echo "linting -> pandas/src/$path" - cpplint --extensions=c,h --headers=h --filter=-readability/casting,-runtime/int,-build/include_subdir --recursive pandas/src/$path + cpplint --quiet --extensions=c,h --headers=h --filter=-readability/casting,-runtime/int,-build/include_subdir --recursive pandas/src/$path if [ $? -ne "0" ]; then RET=1 fi From 39b1da46241cf48bb91d483d2e4dd070e8b04c10 Mon Sep 17 00:00:00 2001 From: gfyoung Date: Mon, 19 Dec 2016 12:05:30 -0500 Subject: [PATCH 2/2] Move cpplint install before checks --- ci/lint.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/lint.sh b/ci/lint.sh index 4ef1141de8c4c..32ac606a4d30a 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -7,6 +7,8 @@ source activate pandas RET=0 if [ "$LINT" ]; then + pip install cpplint + # pandas/rpy is deprecated and will be removed. # pandas/src is C code, so no need to search there. echo "Linting *.py" @@ -43,8 +45,6 @@ if [ "$LINT" ]; then # from Cython files nor do we want to lint C files that we didn't modify for # this particular codebase (e.g. src/headers, src/klib, src/msgpack). However, # we can lint all header files since they aren't "generated" like C files are. - pip install cpplint - echo "Linting *.c and *.h" for path in '*.h' 'period_helper.c' 'datetime' 'parser' 'ujson' do