Skip to content

DOC: clean up some doc-build warnings #12579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 9, 2016

No description provided.

@jreback jreback added the Docs label Mar 9, 2016
@jreback jreback added this to the 0.18.0 milestone Mar 9, 2016
If ``q`` is a float, a Series will be returned where the
index is the columns of self and the values are the quantiles.

- If ``q`` is an array, a DataFrame will be returned where the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so @jorisvandenbossche all of those nasty warnings just needed a blank line before AND after a list when embedded in a doc-string. very confusing message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed, that's the rule for rst lists and also apply in docstrings, unless it's the only thing in the explanation of a parameter (no text before or after in the entry), then no blank lines are needed (eg in this case it is normally not needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I fixed, but that seems a confusing rule. better to just put blanks around lists in doc-strings always, no? (checking if taking these out still has warnings). I was trying things so didn't always take out the added whitespace.

@jreback
Copy link
Contributor Author

jreback commented Mar 9, 2016

only big ones left are these

/Users/jreback/pandas/doc/source/generated/pandas.Series.str.partition.rst:6: WARNING: don't know which module to import for autodocumenting u'Series.str.partition' (try placing a "module" or "currentmodule" directive in the document, or giving an explicit module name)
/Users/jreback/pandas/doc/source/generated/pandas.Series.str.repeat.rst:6: WARNING: don't know which module to import for autodocumenting u'Series.str.repeat' (try placing a "module" or "currentmodule" directive in the document, or giving an explicit module name)

and one on groupby.nth I can't seem to figure out...

* default: don't fill gaps
* pad / ffill: propagate last valid observation forward to next
valid
* backfill / bfill: use next valid observation to fill gap
* nearest: use nearest valid observations to fill gap

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the list above, the extra indentation for the list is also not needed

@jorisvandenbossche
Copy link
Member

On the groupby.nth, I also already looked at before, but didn't spot the error either

@jreback jreback force-pushed the docs branch 2 times, most recently from 1a3bc1e to d4f6d95 Compare March 10, 2016 17:22
@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2016

merged via fcab956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants