-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: add testing functions to public API ? #9895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the 'official' way really to compare is actually |
xref #9457 that discusses some improvements that can be made to these functions. |
OK, but |
ok, so the proposition is to make a public testing module that is the API for pandas testing functions, ok, onboard with that. |
Yes indeed. |
ok, so the proposal is to leave |
That last one of It would also enable to clean up some of the functions (in argument names, defaults, ..) if this would be needed / deemed desired. |
|
This is a good idea - I use assert_(series,frame)_equal in both statsmodels and my own code. |
@sinhrks as you are doing quite some work on the testing functions lately, you are maybe also interested in this one? (any way, I would like to do this for 0.17.0) |
A lot of other projects that use pandas will (like to) use pandas testing functionality like
assert_frame_equal
in their test suite. Although the pandas testing functions are available in the namespace (#6188), they are not really 'officially' labeled as public API that other projects can use (and rely upon).Numpy has a similar submodule
numpy.testing
(http://docs.scipy.org/doc/numpy/reference/routines.testing.html)Some things we could do:
util.testing
that we want to label as publicpandas.testing
module, so it is this one we can publicly advertise (and users are less tempted to use other non-public functions in thepandas.util.testing
namespace)The text was updated successfully, but these errors were encountered: