Skip to content

pandas.Grouper documentation thin #9789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eXcuvator opened this issue Apr 2, 2015 · 6 comments
Closed

pandas.Grouper documentation thin #9789

eXcuvator opened this issue Apr 2, 2015 · 6 comments
Labels
Docs Resample resample method
Milestone

Comments

@eXcuvator
Copy link

The documentation of http://pandas.pydata.org/pandas-docs/dev/generated/pandas.Grouper.html is quite thin, when it comes to additional kwargs to control time-like groupers (when freq is passed):

  • convention is not described at all
  • default values are not described for any of the additional kwargs
@jreback
Copy link
Contributor

jreback commented Apr 2, 2015

time-like grouping is a resample, so the same frequency operators are accepted, including all DateOffsets, see here, so certainly would accept a link to this; don't want to repeat things here however.

@jreback jreback added Docs Resample resample method labels Apr 2, 2015
@jreback jreback added this to the Next Major Release milestone Apr 2, 2015
@Winterflower
Copy link
Contributor

I would like to pick this up, but the link OP posted http://pandas.pydata.org/pandas-docs/dev/generated/pandas.Grouper.html redirects to the pandas frontpage so I am not entirely sure, which page he/she would like to see documented better. Perhaps this http://pandas-docs.github.io/pandas-docs-travis/groupby.html ?

@jorisvandenbossche
Copy link
Member

Ah, yes, the API docs are not included in the latest dev docs, you can look just at the stable docs: http://pandas.pydata.org/pandas-docs/stable/generated/pandas.Grouper.html

@Winterflower
Copy link
Contributor

Thank you @jorisvandenbossche . I'll try to expand the section based on the feedback from @jreback and OP.
The docstring could certainly do with a bit of tidying.
At first I thought that the 'syntactic sugar' part here

df.groupby(Grouper(key='A')) : syntactic sugar for df.groupby('A')

was part of the code (the syntax highlighting on the 'for' is misleading).

@jorisvandenbossche
Copy link
Member

Yes, in those cases everything after the : which is not code but explanation should be on separate lines to make this more clear

@jreback
Copy link
Contributor

jreback commented Aug 20, 2015

closed by #10605

@jreback jreback closed this as completed Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Resample resample method
Projects
None yet
Development

No branches or pull requests

4 participants