-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Status of the examples #9391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
repeat of my comment: I think that these should be checked to see if they are in the docs ; if not and appropriate add any |
Agreed -- they really should go away. I wouldn't even bother fixing them up. |
Yeah, I found it strange that only two examples were there that too outdated. I have closed the other fix related PRs and submitted a new one which deletes the examples folder |
Will check any potential additions to documentation and update PR accordingly. |
@tvyomkesh opened some issues (#9384, #9389) on errors in the examples (and some PRs to fix this). This raised the following question to me:
Apart from fixing the examples, I think we should think for a moment what we want to do with these examples. Why do we want them? What is their function?
And depending on that, do we want to update/extend them? Or maybe move them to the docs?
I personally never looked at these examples. And they are also quite outdated. Eg using the ols from pandas is somewhat (unofficially) deprecated for the use of statsmodels, and the finance module in matplotlib is deprecated starting from matplotlib 1.4. And to get such data, I think pandas-datareader should be used.
@jreback @TomAugspurger @shoyer
The text was updated successfully, but these errors were encountered: