-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
np.float16 support #9220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this is not implemented. Generally |
http://en.wikipedia.org/wiki/Half-precision_floating-point_format generally since operations between lower precision dtypes will silently fail using lower precision is generally not a great idea. |
Sorry to change the title, didn't see that you change it so quick, and I thought it was some kind of github autosuggestion that I didn't see before. ;) |
np happy to have this implemted |
In case someone else has the same problem, my actual code error was on the
Anyway, I'll give it a try, and see if I can add support for the np.float16 dtype to the fill_na method. |
any news on this? I still see errors when using float16. |
happy to take pull requests but we have very little float16 support / and very little testing |
Wow, 5 years now, still an open issue. |
there are about 3400 open issues and a few volunteer core devs it’s all about community contributions / or lack thereof |
While I can understand that complete support for I stumbled upon this issue when I tried to
(The reindexing result for |
We specifically raise for |
open issues & xref
think this should be a bug. When calling the fill_na method in a pandas Series of type np.float16 it raises a ValueError, because of invalid dtype. May be there is a reason for that I can't guess, but I think it's a bug because it does not detect np.float16 as a subclass of np.floating. I'm using Python 3.4, didn't test if it also fails in Python 2. It fails for both methods, 'pad' and 'bfill'.
For np.float32 and np.float64 it works correctly. This code reproduces the error with np.float16:
and this is the ValueError it generates:
And my guess is that the problem is this part of the code, I can debug it once you confirm this is a bug:
https://github.com/pydata/pandas/blob/master/pandas/core/common.py#L2459
The text was updated successfully, but these errors were encountered: