Skip to content

CLN: reorg sorting algos #9020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 6, 2014 · 2 comments
Closed

CLN: reorg sorting algos #9020

jreback opened this issue Dec 6, 2014 · 2 comments
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Internals Related to non-user accessible pandas implementation
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Dec 6, 2014

currently much of the sorting algorithms are in groupby.py (e.g. _index_from_factorized, _lexsort_indexer), the whole section under 'misc utilities'.

I think it makes sense to move these to algorithms.py. (OR maybe to sorting.py). Likewise might make sense to pull out 'sorting' type cython algos and to add a section / extension (or at least group the code a bit more).

xref #9019
@jreback jreback added Internals Related to non-user accessible pandas implementation Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Dec 6, 2014
@jreback jreback added this to the 0.16.0 milestone Dec 6, 2014
@jreback
Copy link
Contributor Author

jreback commented Dec 6, 2014

cc @behzadnouri
cc @immerrr
@shoyer

@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@jreback
Copy link
Contributor Author

jreback commented Feb 27, 2017

closed by #15402

@jreback jreback closed this as completed Feb 27, 2017
@jreback jreback modified the milestones: 0.20.0, Next Major Release Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
1 participant
@jreback