Skip to content

ERR/BUG: df2.fillna(df1) should raise NotImplementedError #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Sep 23, 2014 · 0 comments · Fixed by #8388
Closed

ERR/BUG: df2.fillna(df1) should raise NotImplementedError #8377

jreback opened this issue Sep 23, 2014 · 0 comments · Fixed by #8388
Labels
Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone
0.15.0

Comments

@jreback
Copy link
Contributor

jreback commented Sep 23, 2014

from SO

df2.fillna(df1) should be implemented by:

df2.where(df2.notnull(),df2,df1)
@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Error Reporting Incorrect or improved errors from pandas labels Sep 23, 2014
@jreback jreback modified the milestones: 0.15.0, 0.15.1 Sep 23, 2014
@jreback jreback added Enhancement and removed Error Reporting Incorrect or improved errors from pandas labels Sep 23, 2014
@jreback jreback mentioned this issue Sep 23, 2014
Merged
@unutbu unutbu mentioned this issue Sep 26, 2014
Merged
@jreback jreback modified the milestones: 0.15.0, 0.15.1 Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

EHN: Allow DataFrame.fillna to accept a DataFrame as its fill value. unutbu/pandas
1 participant
@jreback