Skip to content

VIS/DOC: clean-up plots in the docs #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
jorisvandenbossche opened this issue Sep 18, 2014 · 7 comments · Fixed by #8391
Closed
3 tasks done

VIS/DOC: clean-up plots in the docs #8312

jorisvandenbossche opened this issue Sep 18, 2014 · 7 comments · Fixed by #8391
Labels
Milestone

Comments

@jorisvandenbossche
Copy link
Member

This is of course taste, but I personally find some of the plots on the docs not very pleasing to the eyes.
Some different things:

@TomAugspurger
Copy link
Contributor

Agreed. What version of matplotlib are the docs built with? 1.4 added the style method. We could just use the ggplot style

frame_plot_subplots_multi_ax

@jorisvandenbossche
Copy link
Member Author

On travis, the docs are built in the third job, which now uses matplotlib 1.3.1, but I think we should certainly update the matplotlib version of one of the jobs to 1.4, so we can take that one.
For releases, I did the building for the last two releases, so I can just use matplotlib 1.4 when building the docs, that is no problem.

So +1 on using matplotlib.style instead of our own solution with options.display.mpl_style

@jorisvandenbossche jorisvandenbossche changed the title VIS/DOC: disable minor gridlines in plots on the docs? VIS/DOC: clean-up plots in the docs Sep 19, 2014
@jorisvandenbossche jorisvandenbossche added this to the 0.15.0 milestone Sep 19, 2014
@jorisvandenbossche
Copy link
Member Author

@TomAugspurger Strange thing is, if I run the plots locally, eg the first plot http://pandas.pydata.org/pandas-docs/stable/visualization.html#basic-plotting-plot, then I don't get these dense gridlines, but only the major ones. I don't see why it is different in the docs.

UPDATE: seems different between matplotlib version 1.3.1 and 1.4.0. So updating the doc builds to 1.4 would maybe be enough to have less dense gridlines.

@jreback
Copy link
Contributor

jreback commented Oct 2, 2014

@jorisvandenbossche @TomAugspurger ? (going to leave on 0.15.0, but since docs can fiddle even after RC)

@jorisvandenbossche
Copy link
Member Author

@TomAugspurger are we also going to use matplotlib.style ? (ggplot eg)

@TomAugspurger
Copy link
Contributor

👍 for ggplot.

@jorisvandenbossche
Copy link
Member Author

Do you want to do a PR? (I can also do, but then it will be for later after rc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants