Skip to content

SQL: issues with get_schema #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche opened this issue Aug 22, 2014 · 2 comments · Fixed by #8232
Closed

SQL: issues with get_schema #8097

jorisvandenbossche opened this issue Aug 22, 2014 · 2 comments · Fixed by #8232
Labels
IO SQL to_sql, read_sql, read_sql_query
Milestone
0.15.0

Comments

@jorisvandenbossche
Copy link
Member

  • using get_schema in sqlalchemy mode (providing an engine) does also create the table, while just getting the create table string should not have any effects.
  • the get_schema implementation for fallback duplicates a lot of code of PandasSQLTableLegacy._create_table_statement
@jorisvandenbossche jorisvandenbossche added this to the 0.15.0 milestone Aug 22, 2014
@jorisvandenbossche jorisvandenbossche mentioned this issue Aug 22, 2014
Merged
@artemyk
Copy link
Contributor

artemyk commented Aug 22, 2014

In addition, get_schema should return SQL with CREATE INDEX statements as appropriate. Need to add tests for this.

@artemyk
Copy link
Contributor

artemyk commented Sep 10, 2014

@jorisvandenbossche Added an initial (and somewhat experimental) pull request to address this: #8232 . Thoughts?

@artemyk artemyk mentioned this issue Sep 10, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Fix to merge code from _create_table_statement and get_schema artemyk/pandas
2 participants
@artemyk @jorisvandenbossche