Skip to content

csv writer engine 'fast' has a bug #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelaye opened this issue Aug 7, 2014 · 4 comments
Closed

csv writer engine 'fast' has a bug #7956

michaelaye opened this issue Aug 7, 2014 · 4 comments

Comments

@michaelaye
Copy link
Contributor 

rdr2.to_csv('jdate_test_out.csv', index=False)
csvtest = pd.read_csv('jdate_test_out.csv')
print csvtest.jdate.ptp()
rdr2.to_csv('jdate_test_out.csv', index=False, engine='fast')
csvtest = pd.read_csv('jdate_test_out.csv')
print csvtest.jdate.ptp()

0.0416644699872
0.0

Disclaimer: the 'fast' engine came from my own PR, so I messed up somewhere.
@jreback
Copy link
Contributor

jreback commented Aug 7, 2014

why are you opening an issue for ti then?

@michaelaye
Copy link
Contributor Author

i thought it's merged already?

@michaelaye
Copy link
Contributor Author

I must be mistaken, cannot find a merge for it in #3186. Sorry.

@jreback
Copy link
Contributor

jreback commented Aug 7, 2014

nope. that pr needs tests, more tests, and perf validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelaye @jreback