Skip to content

BUG: period partial string slicing failng again numpy master #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue May 13, 2014 · 4 comments · Fixed by #7118
Closed

BUG: period partial string slicing failng again numpy master #7116

jreback opened this issue May 13, 2014 · 4 comments · Fixed by #7118
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves Period Period data type
Milestone
0.14.0

Comments

@jreback
Copy link
Contributor

jreback commented May 13, 2014

xref: #7043

This fails on numpy master for some reason, can you investigate: https://travis-ci.org/pydata/pandas/jobs/25073475
@jreback jreback added this to the 0.14.0 milestone May 13, 2014
@jreback
Copy link
Contributor Author

jreback commented May 13, 2014

cc @sinhrks

@jreback jreback changed the title BUG: period partial string slicing faiilng again numpy master BUG: period partial string slicing failng again numpy master May 13, 2014
@jreback jreback mentioned this issue May 13, 2014
Merged
@sinhrks
Copy link
Member

sinhrks commented May 15, 2014

@jreback Thanks. Is it better to change DatetimeIndex.__getitem__ and PeriodIndex to raise ValueError to be comatible with np 1.8 or earlier? Or just leave as numpy does?

@jreback
Copy link
Contributor Author

jreback commented May 15, 2014

I am just skipping the tests, no biggie: 1b2ad6c

don't want to touch __getitem__ unless we have to, adds overhead

@sinhrks
Copy link
Member

sinhrks commented May 15, 2014

Understood. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves Period Period data type
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

TST: numpy 1.9 -dev exception changes indatetime64 indexing (GH7116) jreback/pandas
2 participants
@jreback @sinhrks