-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: create/drop pandas_nosetest db on class instatiation #7091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jreback If a test fails, then the |
no it is more important I think is that no sql tests can be run by users because they almost certainly don't have the correct database created not sure if that is an issue |
The reason I would rather not do this, is that the tests aren't already that fast, and this will likely slow it down? About having the correct database created for users who run the tests, that is indeed a problem. But I think you will have to configure your setup in any case a bit manually. As it is also not that likely that you have the exact same username/password as what is used in the tests. In that case it is not much work to once create the database I think. |
Ah, but you meant a |
yeh....once for each class (its not really a big deal). though maybe include some method of haveing a user configure the db's and such so they can actually run the tests locally (not sure how to do this) e.g. a method of specifying to nose your db configuration (maybe sqlalchemy has something for this)? |
So I think that the SQL test classes should inherit from:
https://github.com/pydata/pandas/blob/master/pandas/util/testing.py#L65
then you can add
and remove this:
https://github.com/pydata/pandas/blob/master/.travis.yml#L100
This doesn't affect travis, but testing on a static platform (e.g. windows)
where the database in theory could have something in it (if a test was stopped in the middle) and then the next time it runs their is stuff there
The text was updated successfully, but these errors were encountered: