-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: set_option docstring #6838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree this is hard to read. Thoughts on:
I'm happy to PR this if we can agree on a way that makes sense. |
I also completely agree on this with @jseabold, but for the docstrings I already did a PR some time ago (#7236), so it has already improved a bit (but can certainly use some further improvement). See http://pandas.pydata.org/pandas-docs/stable/basics.html#working-with-package-options and http://pandas.pydata.org/pandas-docs/stable/generated/pandas.describe_option.html#pandas.describe_option. But that is only for the docstring, I think the docs can use more improvement at the moment:
I won't directly have the time for this, so if you want to take a try on this, certainly do! |
I guess I'll start tilting at this windmill. I'm not sure it will go well, but, I'm sure I'll learn something. |
Nice! If you have any questions, just ask. Also, if you have already something, you can always open a PR to get initial feedback. You can always furhter update that PR. Here (http://pandas.pydata.org/pandas-docs/stable/contributing.html#contributing-to-the-documentation) are some basic docs about contributing to the documentation. |
@jorisvandenbossche This is coming along. I'm having a bit of trouble with display.column_space; it's not giving the expected results.
In line 30, I would have expected column B to be carried out to 12 places or characters. Am I misunderstanding how this is supposed to work? (I'll also add to the PR getting the description of this option to populate into |
I actually don't know what this should do, @jreback? |
no ideas the give the src/docs a search |
format.py states |
@clham I would say, just leave it out of the PR you are preparing now if you don't directly find it out, and maybe open a new issues about this to remember we have to find out what this exactly does, if it is deprecated or not and to take the appropriate action (or document it, or remove it) |
pushing to 0.15.0 as #7578 was |
Warning. NIt-picky here.
Parking this here as I see it's not quite just a simple edit of a docstring. Might have time for a PR today. This is the current partial docstring of
set_option
. Maybe it's just me, but my eyes have a very hard time finding the actual parameters in here as it doesn't quite conform to the numpy docstring standard and the lines are not 79 characters so they wrap on my terminal (not obvious in the below but tough to grok in the terminal). Any else find this hard to read? Any thoughts on a better format? I think fixing the line lengths, moving the types to the same line as the option, and moving the default/currently to a new indented line at end of the description would go a long way.The text was updated successfully, but these errors were encountered: