Skip to content

BLD: test with an older version of sql alchemy #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Feb 13, 2014 · 2 comments · Fixed by #7022
Closed

BLD: test with an older version of sql alchemy #6340

jreback opened this issue Feb 13, 2014 · 2 comments · Fixed by #7022
Labels
IO SQL to_sql, read_sql, read_sql_query
Milestone
0.14.1

Comments

@jreback
Copy link
Contributor

jreback commented Feb 13, 2014

should be simple to lower the bar to an older version
change recommended min version on install page as well
@jreback jreback added this to the 0.14.0 milestone Feb 13, 2014
@jorisvandenbossche jorisvandenbossche mentioned this issue Feb 13, 2014
Closed
17 tasks
@jreback
Copy link
Contributor Author

jreback commented May 1, 2014

@jorisvandenbossche

what is min version of sqlalchemy you think?

I will just change it (I have to rebuild wheels to do )...no biggie

we test with 0.8.2, 0.9,1, 0.9.3 now...good enough?

@jorisvandenbossche
Copy link
Member

I actually have no idea. We are now testing with 0.8.1 and 0.9. I quickly looked at their migration guide to 0.8.1 and didn't see anything obvious we would need.

They still support both series 0.8 and 0.9 (current releases are 0.8.6 and 0.9.4). And 0.8.1 was released April 27, 2013, so indeed rather recent.

0.7.1 was released Jun 05 2011. So I would just try it and see if the tests pass?

@jreback jreback mentioned this issue May 1, 2014
Merged
@jreback jreback modified the milestones: 0.14.1, 0.14.0 May 14, 2014
@jorisvandenbossche jorisvandenbossche mentioned this issue Jun 4, 2014
Closed
@jorisvandenbossche jorisvandenbossche mentioned this issue Jun 14, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
0.14.1
Development

Successfully merging a pull request may close this issue.

BLD: use sqlalchemy 0.7.1 in 2.6 build (GH6340) jreback/pandas
2 participants
@jreback @jorisvandenbossche