Skip to content

BUG: some cases of binary arithmetic between string and timedelta raise TypeError #59653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 3 tasks
sfc-gh-mvashishtha opened this issue Aug 29, 2024 · 3 comments
Open
2 of 3 tasks
Assignees
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type

Comments

@sfc-gh-mvashishtha
Copy link

sfc-gh-mvashishtha commented Aug 29, 2024

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

pd.Series(pd.Timedelta(1)) + pd.Series(['1'])

Issue Description

The example above should produce pd.Series(pd.Timedelta(2)), but it raises a TypeError instead.

There are some other cases that don't work either:

  • pd.Series(['1']) + pd.Series(pd.Timedelta(1))
  • pd.Timedelta(1) + pd.Series(['1'])
  • pd.Series(pd.Timedelta(1)) + '1'
  • '1' + pd.Series(pd.Timedelta(1))
  • pd.Timedelta(1) + pd.Series('1')

But some cases that do:

  • pd.DataFrame(['1']) + pd.DataFrame([pd.Timedelta(1)])
  • pd.DataFrame([pd.Timedelta(1)]) + pd.DataFrame(['1'])
  • pd.Series(['1']) + pd.Timedelta(1)
  • pd.Series('1') + pd.Timedelta(1)

Expected Behavior

Given that the Timedelta itself seems to support arithmetic with scalar strings, it seems that dataframes and series of timedelta should support arithmetic with strings or data structures containing strings.

Installed Versions

INSTALLED VERSIONS
------------------
commit                : d9cdd2ee5a58015ef6f4d15c7226110c9aab8140
python                : 3.9.18.final.0
python-bits           : 64
OS                    : Darwin
OS-release            : 23.6.0
Version               : Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020
machine               : arm64
processor             : arm
byteorder             : little
LC_ALL                : None
LANG                  : en_US.UTF-8
LOCALE                : en_US.UTF-8

pandas                : 2.2.2
numpy                 : 1.26.3
pytz                  : 2023.3.post1
dateutil              : 2.8.2
setuptools            : 68.2.2
pip                   : 23.3.1
Cython                : None
pytest                : None
hypothesis            : None
sphinx                : None
blosc                 : None
feather               : None
xlsxwriter            : None
lxml.etree            : None
html5lib              : None
pymysql               : None
psycopg2              : None
jinja2                : None
IPython               : 8.18.1
pandas_datareader     : None
adbc-driver-postgresql: None
adbc-driver-sqlite    : None
bs4                   : None
bottleneck            : None
dataframe-api-compat  : None
fastparquet           : None
fsspec                : None
gcsfs                 : None
matplotlib            : None
numba                 : None
numexpr               : None
odfpy                 : None
openpyxl              : None
pandas_gbq            : None
pyarrow               : None
pyreadstat            : None
python-calamine       : None
pyxlsb                : None
s3fs                  : None
scipy                 : None
sqlalchemy            : None
tables                : None
tabulate              : None
xarray                : None
xlrd                  : None
zstandard             : None
tzdata                : 2023.4
qtpy                  : None
pyqt5                 : None
@sfc-gh-mvashishtha sfc-gh-mvashishtha added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 29, 2024
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title BUG: some cases of adding string to timedelta raise TypeError BUG: some cases of binary arithmetic between string and timedelta raise TypeError Aug 29, 2024
@sfc-gh-mvashishtha
Copy link
Author

Also, some operators don't work, e.g. pd.Series(['1']) + pd.Timedelta(1) and pd.Series(['1']) == pd.Timedelta(1) work, but pd.Series(['1']) <= pd.Timedelta(1) does not

@rhshadrach
Copy link
Member

Thanks for the report, confirmed on main. Further investigations and PRs to fix are welcome!

@rhshadrach rhshadrach added Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 8, 2024
@mingjji
Copy link

mingjji commented Nov 14, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type
Projects
None yet
Development

No branches or pull requests

3 participants