Skip to content

DOC: sentence fragment in "String methods" #59231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjandrea opened this issue Jul 11, 2024 · 1 comment · Fixed by #59291
Closed

DOC: sentence fragment in "String methods" #59231

wjandrea opened this issue Jul 11, 2024 · 1 comment · Fixed by #59291
Assignees

Comments

@wjandrea
Copy link
Contributor

wjandrea commented Jul 11, 2024

The type of the Series is inferred and the allowed types (i.e. strings).

Context:

.. warning::
The type of the Series is inferred and the allowed types (i.e. strings).
Generally speaking, the ``.str`` accessor is intended to work only on strings. With very few
exceptions, other uses are not supported, and may be disabled at a later point.

Maybe it wasn't intended this way, but I'm reading it as two independent clauses joined by "and":

  1. "The type of the Series is inferred" - this is fine
  2. "the allowed types (i.e. strings)." - this is a sentence fragment

I'm not sure what it's trying to say. Is it supposed to be something more like this?

The type of the Series and the allowed types (i.e. strings) are inferred.

Or this?

The type of the Series is inferred, as well as the allowed types (i.e. strings).

@wjandrea wjandrea changed the title DOC: sentence fragment DOC: sentence fragment in "String methods" Jul 11, 2024
@jayendhargautham
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants