Skip to content

BUG: docker build on windows fails; need eol=lf in .gitattributes #59000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
pwm1234-sri opened this issue Jun 13, 2024 · 2 comments
Closed
3 tasks done

BUG: docker build on windows fails; need eol=lf in .gitattributes #59000

pwm1234-sri opened this issue Jun 13, 2024 · 2 comments
Labels
Bug Build Library building on various platforms Closing Candidate May be closeable, needs more eyeballs

Comments

@pwm1234-sri
Copy link

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

``python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true`` fails when run in a docker container on a windows host.

Issue Description

I followed Option 3 Using Docker instructions to set up a pandas build environment. When I ran the pip install command in my container on a windows host, the build failed because generate_version.py has CRLF line endings. (I checked, my ~/.gitconfig and it has autocrlf=false.) But CRLF line endings are not allowed in a shebang script. When I added eol=lf to line 1 of .gitattributes the problem went away. So, I think line 1 of .gitattributes should be

* text=auto eol=lf

Expected Behavior

For python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true to succeed.

Installed Versions

2.2.2

@pwm1234-sri pwm1234-sri added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 13, 2024
@Aloqeely
Copy link
Member

Thanks for the report! There's an open issue to track bug reports related to meson in #49683, could you report there instead?

I also have had that issue when building using Docker on Windows and have posted there.

@Aloqeely Aloqeely added Build Library building on various platforms Closing Candidate May be closeable, needs more eyeballs and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 13, 2024
@pwm1234-sri
Copy link
Author

Yes, this looks to be the exact same error as you mention in #49683 (comment). Since there is already this link that shows up, is there anything else I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build Library building on various platforms Closing Candidate May be closeable, needs more eyeballs
Projects
None yet
Development

No branches or pull requests

2 participants