Skip to content

Potential performance regression with "BUG: DateTimeIndex.is_year_start unexpected behavior when constructed…" #58997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeaMariaLeon opened this issue Jun 13, 2024 · 1 comment
Labels
Benchmark Performance (ASV) benchmarks

Comments

@DeaMariaLeon
Copy link
Member

PR #57494

@mattheeter

{
"tslibs.fields.TimeGetDateField.time_get_date_field (Python) with field='s', size=1000000": "http://57.128.112.95:5000/compare/benchmarks/066639a2084f75ab8000e6252b6a277a...066647f1be1a7f878000e6f25fe386d1",
"tslibs.fields.TimeGetDateField.time_get_date_field (Python) with field='M', size=1000000": "http://57.128.112.95:5000/compare/benchmarks/066639a205f975a580001752d162969b...066647f1bba577c78000f3cc52b36eca",
"tslibs.fields.TimeGetDateField.time_get_date_field (Python) with field='doy', size=1000000": "http://57.128.112.95:5000/compare/benchmarks/066639a20a157acf800052022a1021a8...066647f1bfb77cbb8000eeb799121073",
"tslibs.fields.TimeGetDateField.time_get_date_field (Python) with field='doy', size=10000": "http://57.128.112.95:5000/compare/benchmarks/066639a201ec71228000b75645555199...066647f1b762714e8000123e3c46ad25"
}

Screenshot 2024-06-13 at 10 55 21
@DeaMariaLeon DeaMariaLeon added the Benchmark Performance (ASV) benchmarks label Jun 13, 2024
@Aloqeely
Copy link
Member

Thanks for the report! That PR looks good to me, and this change is too small to worry about so going to close as expected increase from the bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

No branches or pull requests

2 participants