Skip to content

WEB: Follow us buttons in the pandas home page not displaying #57165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Jan 31, 2024 · 7 comments · Fixed by #57226
Closed

WEB: Follow us buttons in the pandas home page not displaying #57165

datapythonista opened this issue Jan 31, 2024 · 7 comments · Fixed by #57226
Assignees
Labels

Comments

@datapythonista
Copy link
Member

In the section Follow us in https://pandas.pydata.org/ we should have links our social media. But seems like the JavaScript we link from Font Awesome is returning a 403 Forbidden, and the links are broken. Not sure why the link that used to work now it's not, we should do some research, and make the JavaScript load correctly so the icons are properly displayed.

The header of the website with the link to the JavaScript is in web/_templates/layout.html.

@koushik-rout-samsung
Copy link
Contributor

take

@remiBoudreau
Copy link

@koushik-rout-samsung let me know if you need help pointing you in the right direction.

@koushik-rout-samsung
Copy link
Contributor

koushik-rout-samsung commented Feb 1, 2024

@datapythonista @remiBoudreau I was able to solve it by updating the kit from fontawesome. I have used my own kit, is it advisable or there should be some common kit for using ? Also i have tested it in live browser, do i need the development setup for web if yes share the steps. Thanks.

@datapythonista
Copy link
Member Author

Not sure what do you mean by your own kit. Ideally we'd want to continue a CDN for the javacsript, so we don't need to add the file to the pandas repo. But if there are no reliable CDNs for this (I'm pretty sure there are), we can also add the file.

Feel free to open a pull request and tag me, so I can have a look at what you did. Thanks!

@koushik-rout-samsung
Copy link
Contributor

koushik-rout-samsung commented Feb 1, 2024

@datapythonista actually the code is referring to some script which have changed the policies for usage. I will open a PR for this. The link below contains the details. Thanks.
FortAwesome/Font-Awesome#17645

@datapythonista
Copy link
Member Author

Ah, thank you, I see what you mean now, thanks for sharing that link.

I think this is more complex than initially expected. I created a kit using pandas credentials, but I see that the free plan comes with 10,000 pageviews per month, which is far from enough for pandas. I can't easily check how many pageviews we've got in the website, but only the home page has 350k/month, so not clear if the $99/year plan is enough. And not sure if worth paying just for couple of social media icons in the website. I guess we may want to use another alternative.

@koushik-rout-samsung
Copy link
Contributor

@datapythonista Thanks for the reply. I will check for any alternative and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants