Skip to content

DEP: Deprecate date_format="epoch" in to_json #57063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
WillAyd opened this issue Jan 25, 2024 · 2 comments · Fixed by #57987
Closed
1 of 3 tasks

DEP: Deprecate date_format="epoch" in to_json #57063

WillAyd opened this issue Jan 25, 2024 · 2 comments · Fixed by #57987
Labels
Deprecate Functionality to remove in pandas IO JSON read_json, to_json, json_normalize

Comments

@WillAyd
Copy link
Member

WillAyd commented Jan 25, 2024

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

While date_format="epoch" made sense when we exclusively handled ns-precision timestamps since the epoch, it has started to lose its meaning as we support other precisions.

If you try to roundtrip JSON produced with this argument you just have to guess what the precision is

Feature Description

See above

Alternative Solutions

See above

Additional Context

No response

@WillAyd WillAyd added IO JSON read_json, to_json, json_normalize Deprecate Functionality to remove in pandas labels Jan 25, 2024
@Aloqeely
Copy link
Member

So after this change, to_json will only support the iso date format? Not sure how I feel about this, but I'm open to working on it as long as nobody's opposed

@WillAyd
Copy link
Member Author

WillAyd commented Mar 24, 2024

@Aloqeely that is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants