Skip to content

BUG: Floordiv with arrow types rounds towards 0 instead of negative infinity #55561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
rohanjain101 opened this issue Oct 17, 2023 · 0 comments · Fixed by #55562
Closed
3 tasks done

BUG: Floordiv with arrow types rounds towards 0 instead of negative infinity #55561

rohanjain101 opened this issue Oct 17, 2023 · 0 comments · Fixed by #55562
Labels
Arrow pyarrow functionality Bug Needs Triage Issue that has not been reviewed by a pandas team member Numeric Operations Arithmetic, Comparison, and Logical operations

Comments

@rohanjain101
Copy link
Contributor

rohanjain101 commented Oct 17, 2023

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

>>> a = pd.Series([-7], dtype="int64[pyarrow]")
>>> b = pd.Series([4], dtype="int64[pyarrow]")
>>> a // b
0   -1
dtype: int64[pyarrow]
>>>

Issue Description

Expected result is -2.

Expected Behavior

>>> -7 // 4
-2
>>>

Expected is same behavior as python floordiv (rounding towards negative infinity, not 0). Floordiv with numpy types also matches this behavior:

>>> a = pd.Series([-7])
>>> b = pd.Series([4])
>>> a // b
0   -2
dtype: int64
>>>

Installed Versions

INSTALLED VERSIONS

commit : e86ed37
python : 3.11.2.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.22621
machine : AMD64
processor : Intel64 Family 6 Model 85 Stepping 7, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : English_United States.1252

pandas : 2.1.1
numpy : 1.25.2
pytz : 2023.3
dateutil : 2.8.2
setuptools : 68.0.0
pip : 23.2.1
Cython : None
pytest : 7.0.1
hypothesis : None
sphinx : 4.2.0
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 3.1.2
IPython : 8.14.0
pandas_datareader : None
bs4 : 4.12.2
bottleneck : None
dataframe-api-compat: None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 13.0.0
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : 0.9.0
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.3
qtpy : None
pyqt5 : None

@rohanjain101 rohanjain101 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 17, 2023
@rohanjain101 rohanjain101 changed the title BUG: Floordiv with arrow types produces unexpected result BUG: Floordiv with arrow types rounds towards 0 instead of negative infinity Oct 17, 2023
@simonjayhawkins simonjayhawkins added Arrow pyarrow functionality Numeric Operations Arithmetic, Comparison, and Logical operations labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Bug Needs Triage Issue that has not been reviewed by a pandas team member Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants