Skip to content

BUG: pd.merge returns different column order if dataframe contains 0 rows #55250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
rohanjain101 opened this issue Sep 22, 2023 · 3 comments
Closed
2 of 3 tasks
Labels
Bug Closing Candidate May be closeable, needs more eyeballs Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@rohanjain101
Copy link
Contributor

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

>>> df_a = pd.DataFrame({"Col0": pd.Series([], dtype="int32[pyarrow]"), "Col1": pd.Series([], dtype="int32[pyarrow]"), "Col2": pd.Series([], dtype="int32[pyarrow]")})
>>> df_b = pd.DataFrame({"Col0": pd.Series([], dtype="int32[pyarrow]"), "Col1": pd.Series([], dtype="int32[pyarrow]"), "Col2": pd.Series([], dtype="int32[pyarrow]")})
>>> pd.merge(df_a, df_b,left_on=["Col0", "Col2"], right_on=["Col1", "Col2"])
Empty DataFrame
Columns: [Col0_x, Col1_x, Col0_y, Col1_y, Col2]
Index: []

>>> df_a = pd.DataFrame({"Col0": pd.Series([1], dtype="int32[pyarrow]"), "Col1": pd.Series([1], dtype="int32[pyarrow]"), "Col2": pd.Series([1], dtype="int32[pyarrow]")})
>>> df_b = pd.DataFrame({"Col0": pd.Series([1], dtype="int32[pyarrow]"), "Col1": pd.Series([1], dtype="int32[pyarrow]"), "Col2": pd.Series([1], dtype="int32[pyarrow]")})
>>> pd.merge(df_a, df_b,left_on=["Col0", "Col2"], right_on=["Col1", "Col2"])
   Col0_x  Col1_x  Col2  Col0_y  Col1_y
0       1       1     1       1       1
>>>

Issue Description

Above example performs 2 joins, both input schemas are the same, but the returned schema by pd.merge is different if there are 0 rows vs atleast 1 row, input schema for both dfs was [Col0, Col1, Col2]. When there are 0 rows, pd.merge returns schema as [Col0_x, Col1_x, Col0_y, Col1_y, Col2]

When there's atleast 1 row, schema is returned as [Col0_x, Col1_x, Col2, Col0_y, Col1_y]. The position of Col2 differs if df contain 0 rows vs atleast 1 row.

Expected Behavior

I would expect output schema to always be returned as [Col0_x, Col1_x, Col2, Col0_y, Col1_y].

Installed Versions

INSTALLED VERSIONS

commit : e86ed37
python : 3.11.2.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.22621
machine : AMD64
processor : Intel64 Family 6 Model 85 Stepping 7, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : English_United States.1252

pandas : 2.1.1
numpy : 1.25.2
pytz : 2023.3
dateutil : 2.8.2
setuptools : 68.0.0
pip : 23.2.1
Cython : None
pytest : 7.0.1
hypothesis : None
sphinx : 4.2.0
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 3.1.2
IPython : 8.14.0
pandas_datareader : None
bs4 : 4.12.2
bottleneck : None
dataframe-api-compat: None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 13.0.0
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : 0.8.9
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.3
qtpy : None
pyqt5 : None

@rohanjain101 rohanjain101 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 22, 2023
@rohanjain101 rohanjain101 changed the title BUG: pd.merge returns different rows if dataframe contains 0 rows BUG: pd.merge returns different schema if dataframe contains 0 rows Sep 22, 2023
@rohanjain101 rohanjain101 changed the title BUG: pd.merge returns different schema if dataframe contains 0 rows BUG: pd.merge returns different column order if dataframe contains 0 rows Sep 22, 2023
@mroeschke
Copy link
Member

Thanks for the report. Can reproduce this on main.

Noting that this is independent of the Arrow dtype in your example

@mroeschke mroeschke added Reshaping Concat, Merge/Join, Stack/Unstack, Explode and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 22, 2023
@lukemanley
Copy link
Member

Thanks for the report. Can reproduce this on main.

@mroeschke - are you actually able to reproduce on main? I cannot reproduce and I think #55028 probably fixed this.

@lukemanley lukemanley added the Closing Candidate May be closeable, needs more eyeballs label Sep 23, 2023
@rohanjain101
Copy link
Contributor Author

Thanks @lukemanley, yes this looks fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Closing Candidate May be closeable, needs more eyeballs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

No branches or pull requests

3 participants