Skip to content

DOC: pd to_datetime #55239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
PabloRuizCuevas opened this issue Sep 22, 2023 · 6 comments
Closed
1 task done

DOC: pd to_datetime #55239

PabloRuizCuevas opened this issue Sep 22, 2023 · 6 comments
Assignees
Labels

Comments

@PabloRuizCuevas
Copy link
Contributor

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/reference/api/pandas.to_datetime.html

Documentation problem

in pandas to datetime we find that the default value of the parameter exact is:

exact=_NoDefault.no_default

which i don't know what does it mean, on top of that there is inconsistent breaking behavior from last version when parsing:
"%Y-%m-%d" if a date contains %H:%M:%S so for me they have changed the default value from false to true in pandas v2

Suggested fix for documentation

Probably now should be true before it was false

@PabloRuizCuevas PabloRuizCuevas added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 22, 2023
@Ruth-Nadel
Copy link

take

@cemmanuelsr
Copy link

take

@Nrezhang
Copy link
Contributor

take

@Nrezhang
Copy link
Contributor

is there a reason that exact is exact: bool | lib.NoDefault = lib.no_default, and not exact: bool = True? Should the documentation be changed to be consistent with what is written or is it ok to change it to exact: bool = True

@Aloqeely
Copy link
Member

Thank you for this report, I believe this issue is already resolved, if you scroll down in the documentation to the parameters section, you can see it says the default value for exact is in fact True.

@lithomas1 lithomas1 removed the Needs Triage Issue that has not been reviewed by a pandas team member label Mar 28, 2024
@lithomas1
Copy link
Member

Yep, I think this is closable now.

The parameter should still show up as no_default in the header section i.e.
image

but I don't think there's a way to change that as it is autogenerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants