Skip to content

TST: Add tests for DataFrame/Series.value_counts with missing categories #54836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Aug 29, 2023 · 2 comments · Fixed by #54837
Closed

TST: Add tests for DataFrame/Series.value_counts with missing categories #54836

rhshadrach opened this issue Aug 29, 2023 · 2 comments · Fixed by #54837
Assignees
@rsm-23
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Categorical Categorical Data Type good first issue Needs Tests Unit test(s) needed to prevent regressions
Milestone
2.2

Comments

@rhshadrach
Copy link
Member

From #54789, it seems to me we didn't have any test coverage for Series/DataFrame.value_counts with categoricals. We still don't have any test coverage for these methods where the categorical has missing categories, e.g. pd.Categorical([1, 2, 4], categories=[1, 2, 3, 4]). Tests for these cases should be added.
@rhshadrach rhshadrach added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Categorical Categorical Data Type good first issue Needs Tests Unit test(s) needed to prevent regressions labels Aug 29, 2023
@rhshadrach rhshadrach mentioned this issue Aug 29, 2023
Merged
5 tasks
@rsm-23
Copy link
Contributor

rsm-23 commented Aug 29, 2023

take

@rsm-23 rsm-23 mentioned this issue Aug 29, 2023
Merged
3 tasks
@KalaitziMaria
Copy link

Hello, thank you for the issue, i would like to contribute to pandas library, i saw that this is a good first issue, and i would like to help. Could you tell how i can help because its my first time contributing to an issue.
Thank you.

@rhshadrach rhshadrach added this to the 2.2 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsm-23 rsm-23

Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Categorical Categorical Data Type good first issue Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

TST: added test for missing categories for value_counts rsm-23/pandas
3 participants
@rhshadrach @KalaitziMaria @rsm-23