Skip to content

ENH: #54741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
mikekeith52 opened this issue Aug 24, 2023 · 2 comments
Closed
1 of 3 tasks

ENH: #54741

mikekeith52 opened this issue Aug 24, 2023 · 2 comments
Labels
Needs Info Clarification about behavior needed to assess issue

Comments

@mikekeith52
Copy link

mikekeith52 commented Aug 24, 2023

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

When using connection objects in pd.read_sql(), if non sqlalchemy engine objects are passed to the con argument, it raises this warning:

UserWarning: pandas only supports SQLAlchemy connectable (engine/connection) or database string URI or sqlite3 DBAPI2 connection. Other DBAPI2 objects are not tested. Please consider using SQLAlchemy.

Feature Description

Get rid of the warning. It is clearly not relevant anymore. See #51015. I can use "untested" objects that work so I don't think this warning has any utility.

Alternative Solutions

Fix pd.read_sql() so that the engine object from sqlalchemy > 2.0 works.

Additional Context

No response

@mikekeith52 mikekeith52 added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 24, 2023
@phofl
Copy link
Member

phofl commented Aug 25, 2023

We don't have any test coverage for this, so there aren't any guarantees. You can use that but it's at your own risk.

We fixed compatibility months ago, we will need a reproducer if you think that something is still broken

@phofl phofl added Needs Info Clarification about behavior needed to assess issue and removed Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 25, 2023
@mikekeith52
Copy link
Author

Sorry, you're right. I was having a very frustrating day yesterday (new work-issued laptop) and didn't realize my pandas had been downgraded to 1.5.6 or somewhere around there. I upgraded again to 2.0.3 and the engine object works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Info Clarification about behavior needed to assess issue
Projects
None yet
Development

No branches or pull requests

2 participants