Skip to content

DOC: test results link in asv benchmarks doc is broken #53851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Charlie-XIAO opened this issue Jun 26, 2023 · 4 comments · Fixed by #53902
Closed
1 task done

DOC: test results link in asv benchmarks doc is broken #53851

Charlie-XIAO opened this issue Jun 26, 2023 · 4 comments · Fixed by #53902
Labels
Benchmark Performance (ASV) benchmarks Docs

Comments

@Charlie-XIAO
Copy link
Contributor

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#running-the-performance-test-suite

Documentation problem

Performance matters and it is worth considering whether your code has introduced performance regressions. pandas is in the process of migrating to asv benchmarks to enable easy monitoring of the performance of critical pandas operations. These benchmarks are all found in the pandas/asv_bench directory, and the test results can be found here.

The link in the test results can be found here leads to 404 not found.

Suggested fix for documentation

Use a valid link.

@Charlie-XIAO Charlie-XIAO added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 26, 2023
@Charlie-XIAO Charlie-XIAO changed the title DOC: DOC: test results link in asv benchmarks doc is broken Jun 26, 2023
@lithomas1
Copy link
Member

This is probably the correct link.
https://asv-runner.github.io/asv-collection/pandas/#/
The runner might have gone down though, everything I can see is from last month.

cc @rhshadrach

@lithomas1 lithomas1 added Benchmark Performance (ASV) benchmarks and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 26, 2023
@rhshadrach
Copy link
Member

Thanks @lithomas1 - agreed, looks like the machine restarted. I'll hopefully be able to get it back up in the next day or two.

@Charlie-XIAO
Copy link
Contributor Author

This is probably the correct link.
https://asv-runner.github.io/asv-collection/pandas/#/

Then I'll make a PR using this link.

@rhshadrach
Copy link
Member

rhshadrach commented Jun 29, 2023

The benchmark machine is now back online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants