Skip to content

ENH: add engine_kwargs to DataFrame.to_excel #52368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
rmhowe425 opened this issue Apr 2, 2023 · 4 comments · Fixed by #53220
Closed
1 of 3 tasks

ENH: add engine_kwargs to DataFrame.to_excel #52368

rmhowe425 opened this issue Apr 2, 2023 · 4 comments · Fixed by #53220
Assignees
Labels
Enhancement IO Excel read_excel, to_excel

Comments

@rmhowe425
Copy link
Contributor

rmhowe425 commented Apr 2, 2023

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

Currently the DataFrame.to_excel method does not allow users to pass keyword arguments directly to the Excel engine that is performing read / write operations on the users behalf.

Passing keyword arguments to excel engines can be helpful for many reasons, as seen in issue #40274

Feature Description

The implementation would follow the same logic seen in PR #52214:

  • Add engine_kwargs to the method to_excel
  • engine_kwargs would be passed down to the ExcelWriter class and to all Excel engine _write_cells methods

Alternative Solutions

N/A

Additional Context

No response

@rmhowe425 rmhowe425 added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 2, 2023
@rmhowe425
Copy link
Contributor Author

take

@rmhowe425
Copy link
Contributor Author

rmhowe425 commented Apr 2, 2023

@rhendric

Created this enhancement request as discussed here

@rhendric
Copy link
Contributor

rhendric commented Apr 2, 2023

I'm not the user you meant to ping.

@rmhowe425
Copy link
Contributor Author

@rhshadrach

@DeaMariaLeon DeaMariaLeon added IO Excel read_excel, to_excel and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants