STYLE enable ruff PLW2901

[MarcoGorelli]

Task is:

1. check the contributing guide for how to set up your environment
2. remove PLW2901 from

pandas/pyproject.toml

Lines 272 to 273 in 2c10d93

	# Outer loop variable overwritten by inner assignment
	"PLW2901",

3. run pre-commit run ruff --all-files
4. fixup the errors it flags - see https://beta.ruff.rs/docs/rules/redefined-loop-name/ for more info on this error
5. stage, commit, push, open pull request

[ErdiTk]

Hi Marco, may I help for this issue?

[MarcoGorelli]

sure, go ahead

[ErdiTk]

Take

[ErdiTk]

After removing it and running pre-commit run ruff --all-files, I found 186 errors. I will start tackling them by tomorrow. Shall I go over them one by one right? Seems like the issue is as described in your link.
If I add the following line of code (based on your comment on #51709 ) the amount of errors goes to 125:
"pandas/core/*" = ["PLR5501"]

[MarcoGorelli]

yeah sounds good - and feel free to ignore other folders too if the number of remaining issues is too many

[ErdiTk]

I grouped the issues under the "to be gradually enabled" section and resolved the isolated once. Unfortunately today I had limited time to dedicate to it. The changes seems to be a renaming of the variables which get overwritten. I can continue and do all of them if that's fine for you. For now I changed something like this:

for foo in bar:
    foo = function_x()
return foo

Into this:

for foo in bar:   
    foo_new = function_x()
return foo_new

Please let me know if you think there is another approach for it.

[ErdiTk]

I generated the PR to show you the changes. If it's fine for you I can update the PR by continuing the resolution of "to be gradually enabled" items I added.

[The-Nesh]

Hi Marco, can you please explain why this issue was reopened? I would like to help with it. Thanks!

[MarcoGorelli]

It was probably an accident - thanks!