Skip to content

DOC: Remove reference to sql fallback support for mysql connection objects #51263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
cdcadman opened this issue Feb 9, 2023 · 0 comments · Fixed by #51275
Closed
1 task done

DOC: Remove reference to sql fallback support for mysql connection objects #51263

cdcadman opened this issue Feb 9, 2023 · 0 comments · Fixed by #51275
Labels
Docs Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@cdcadman
Copy link
Contributor

cdcadman commented Feb 9, 2023

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://github.com/pandas-dev/pandas/blob/main/doc/source/user_guide/io.rst#sql-queries

Documentation problem

The user guide states that mysql connections are still supported. Currently, pandas emits a warning if users try to pass a mysql connection to read_sql or DataFrame.to_sql (#45679)

Suggested fix for documentation

Currently, pandas emits a warning if users try to pass a mysql connection to read_sql or DataFrame.to_sql, so I would recommend changing the following paragraph in io.rst

If SQLAlchemy is not installed, a fallback is only provided for sqlite (and
for mysql for backwards compatibility, but this is deprecated and will be
removed in a future version).
This mode requires a Python database adapter which respect the `Python
DB-API <https://www.python.org/dev/peps/pep-0249/>`__.

to

If SQLAlchemy is not installed, you can use a `sqlite3.Connection` object instead.
@cdcadman cdcadman added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant