Skip to content

REGR: SeriesGroupBy.value_counts failure on Windows #50920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Jan 21, 2023 · 5 comments
Closed

REGR: SeriesGroupBy.value_counts failure on Windows #50920

rhshadrach opened this issue Jan 21, 2023 · 5 comments
Assignees
@rhshadrach
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Groupby Needs Info Clarification about behavior needed to assess issue Regression Functionality that used to work in a prior pandas version Windows Windows OS
Milestone
2.0.4

Comments

@rhshadrach
Copy link
Member

Ref: #50761 (comment)

It appears there is a test failing that hasn't shown up on the CI. I'm guessing it might be because it's marked as slow and only fails on Windows.

Putting this on the 2.0 Milestone as it doesn't fail on 1.5.x.
@rhshadrach rhshadrach added Groupby Regression Functionality that used to work in a prior pandas version Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Jan 21, 2023
@rhshadrach rhshadrach added this to the 2.0 milestone Jan 21, 2023
@rhshadrach rhshadrach mentioned this issue Jan 21, 2023
Merged
3 tasks
@lithomas1 lithomas1 added the Windows Windows OS label Jan 21, 2023
@mroeschke mroeschke modified the milestones: 2.0, 3.0 Feb 8, 2023
@rhshadrach
Copy link
Member Author

@mroeschke - I'm moving this to 2.0.1 since it's a regression from 1.5.x. Let me know if you think differently.

@rhshadrach rhshadrach modified the milestones: 3.0, 2.0.1 Apr 22, 2023
@datapythonista datapythonista modified the milestones: 2.0.1, 2.0.2 Apr 23, 2023
@datapythonista datapythonista modified the milestones: 2.0.2, 2.0.3 May 26, 2023
@lithomas1 lithomas1 added the Needs Info Clarification about behavior needed to assess issue label Jun 27, 2023
@lithomas1 lithomas1 modified the milestones: 2.0.3, 2.0.4 Jun 27, 2023
@lithomas1
Copy link
Member

Pushing off of 2.0.3.

@rhshadrach
Do you know if this is still failing on main/2.0.x?

I don't have Windows, so it's not convenient for me to check. If this is still open by 2.0.4, though, I boot up something on OVH and check by hand.

@rhshadrach
Copy link
Member Author

I'm in the same situation @lithomas. But I think I can modify the tests to see if it still exists via our Windows runner. I'll take this up in the next day or two.

@rhshadrach rhshadrach self-assigned this Jun 28, 2023
@rhshadrach rhshadrach mentioned this issue Jun 30, 2023
Closed
5 tasks
@rhshadrach
Copy link
Member Author

No longer able to reproduce in #53943

@lithomas1
Copy link
Member

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhshadrach rhshadrach

Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Groupby Needs Info Clarification about behavior needed to assess issue Regression Functionality that used to work in a prior pandas version Windows Windows OS
Projects
None yet
Milestone
2.0.4
Development

No branches or pull requests
4 participants
@datapythonista @mroeschke @rhshadrach @lithomas1