Skip to content

DEPR: Unnecessary kwargs in groupby ops #50407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhshadrach opened this issue Dec 23, 2022 · 0 comments
Open

DEPR: Unnecessary kwargs in groupby ops #50407

rhshadrach opened this issue Dec 23, 2022 · 0 comments
Labels
Deprecate Functionality to remove in pandas Groupby

Comments

@rhshadrach
Copy link
Member

Some groupby ops have args and/or kwargs unnecessarily.

  • cummax
  • cummin
  • cumsum
  • cumprod
  • take
  • skew

These should be deprecated. For the cum* methods, the kwargs that are used should be added to the function signature (e.g. skipna).
@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas labels Dec 23, 2022
@ramvikrams ramvikrams mentioned this issue Dec 29, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: Remove unnecessary kwargs in groupby ops
1 participant
@rhshadrach