Skip to content

ENH: Use explicit arguments in DataFrameGroupBy.describe #50406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Dec 23, 2022 · 9 comments · Fixed by #50653
Closed

ENH: Use explicit arguments in DataFrameGroupBy.describe #50406

rhshadrach opened this issue Dec 23, 2022 · 9 comments · Fixed by #50653
Assignees
@asadullahnaeem
Labels
Enhancement good first issue Groupby
Milestone
2.0

Comments

@rhshadrach
Copy link
Member

Currently DataFrameGroupBy.describe uses **kwargs instead of explicit arguments. These eventually get passed to DataFrame.describe. We should use explicit arguments, those from DataFrame.describe, instead.
@dullibri
Copy link
Contributor

take

@asadullahnaeem
Copy link
Contributor

asadullahnaeem commented Jan 4, 2023 •
edited
Loading

@dullibri if you are not working on this I would like to take it.

@dullibri dullibri removed their assignment Jan 4, 2023
@dullibri
Copy link
Contributor

dullibri commented Jan 4, 2023

Here you go!

@asadullahnaeem
Copy link
Contributor

asadullahnaeem commented Jan 4, 2023 •
edited
Loading

@rhshadrach I will be working on this issue. I might need your help.

@dullibri
Copy link
Contributor

dullibri commented Jan 4, 2023

I think I was actually pretty close. However, the signature would not change always showing kwargs.

@telferm57
Copy link
Contributor

@dullibri could you 'take', so issue shows as assigned ?

@dullibri
Copy link
Contributor

dullibri commented Jan 9, 2023

@telferm57 read the message above pls.

@asadullahnaeem
Copy link
Contributor

take

@asadullahnaeem asadullahnaeem mentioned this issue Jan 10, 2023
Merged
5 tasks
@asadullahnaeem
Copy link
Contributor

@rhshadrach Could you please review the pull request?

@rhshadrach rhshadrach added this to the 2.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asadullahnaeem asadullahnaeem

Labels
Enhancement good first issue Groupby
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

ENH: Added explicit arguments in DataFrameGroupBy.describe by replacing **… asadullahnaeem/pandas
4 participants
@dullibri @telferm57 @rhshadrach @asadullahnaeem