-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST 56 tests in pandas/tests/test_generic.py aren't being tested #50380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
take |
@MarcoGorelli I tried |
🤔 I thought and thanks for working on this! |
@MarcoGorelli I'm working on it and learning a lot. I wasn't sure that I knew enough programming to get it, but after some digging, things are starting to make sense. I learned what the |
@MarcoGorelli I've spent a long time on this and I've learned a ton and can read the code in the tests much better now, and understand much more about Pandas and even NumPy. I was writing here to ask some questions and to say that I know that I can't spend forever on this and that I would unassign soon if I was still working through things, but then I got I don't know if the test is correct now, but I'm very encouraged that I at least got it to pass. If it's okay, let me spend the rest of the day to try to get the other tests to pass, and I'll get a pull request in tomorrow morning or leave a message and somebody else can do it if necessary. Thank you. |
hey @phershbe thanks for the update! there's no hurry here, and it's OK to submit a PR which only fix some of the tests and xfails others |
@MarcoGorelli Awesome, thank you. I got the first and second of the five tests to past. I'm on the third now. I should be done soon. |
All these tests aren't actually being run:
pandas/pandas/tests/generic/test_generic.py
Lines 53 to 306 in 2ffb748
that's because the class name is
Generic
, rather thanTestGeneric
They're all uncovered in the coverage report: https://app.codecov.io/gh/pandas-dev/pandas/blob/main/pandas/tests/generic/test_generic.py
Similar to #50378, the class needs renaming, and the tests fixing up
The text was updated successfully, but these errors were encountered: