Skip to content

DEV add back boto3 and botocore to requirements-dev.txt #50300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Dec 16, 2022 · 2 comments
Closed

DEV add back boto3 and botocore to requirements-dev.txt #50300

MarcoGorelli opened this issue Dec 16, 2022 · 2 comments
Labels
Dependencies Required and optional dependencies

Comments

@MarcoGorelli
Copy link
Member

xref #50295 (comment)

These packages are already brought in by s3fs and moto. By not listing them explicitly, the time it takes to pip install -r requirements-dev.txt goes from >54 minutes to <3 minutes.

It would be good, however, to list everything that's explicitly used - is there way to put them back without impacting pip install time?

@WillAyd
Copy link
Member

WillAyd commented Dec 20, 2022

I ran into a similar issue working on #50046 I think botocore has a ton of releases on pypi (almost nightly) and that takes a lot of package downloads for pip to resolve.

pip has some strategies for this, the easiest which may be to set a higher version floor for these libraries

https://pip.pypa.io/en/latest/topics/dependency-resolution/#possible-ways-to-reduce-backtracking

--use-deprecated=legacy-resolver also helps as a quick "fix"

@MarcoGorelli
Copy link
Member Author

addressed by #50295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

No branches or pull requests

2 participants