Skip to content

WARN: warning shown when parsing delimited date string even if users can't do anything about it #50231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
MarcoGorelli opened this issue Dec 13, 2022 · 2 comments · Fixed by #50232
Closed
3 tasks done
Labels
Bug Datetime Datetime data dtype

Comments

@MarcoGorelli
Copy link
Member

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

In [2]: Timestamp('13-01-2000')
<ipython-input-2-710ff60ba7e6>:1: UserWarning: Parsing dates in DD/MM/YYYY format when dayfirst=False (the default) was specified. This may lead to inconsistently parsed dates! Specify a format to ensure consistent parsing.
  Timestamp('13-01-2000')
Out[2]: Timestamp('2000-01-13 00:00:00')

Issue Description

This was added in #42908

This helped warn about some of the inconsistencies in #12585, but it's now unnecessary

This warning only shows up when using Timestamp - however, users can't pass format or dayfirst to Timestamp, so the warning is unnecessary

If people use to_datetime, there's already the more informative message(s) from PDEP4:

In [1]: to_datetime('13-01-2000')
<ipython-input-1-9a129e754905>:1: UserWarning: Parsing dates in %d-%m-%Y format when dayfirst=False was specified. Pass `dayfirst=True` or specify a format to silence this warning.
  to_datetime('13-01-2000')
Out[1]: Timestamp('2000-01-13 00:00:00')

If we remove the warning from parse_delimited_date, then to_datetime will keep its informative warnings from PDEP4, and Timestamp will no longer show a warning which users can't do anything about

Expected Behavior

In [2]: Timestamp('13-01-2000')
Out[2]: Timestamp('2000-01-13 00:00:00')

Installed Versions

Traceback (most recent call last):
File "", line 1, in
File "/home/marcogorelli/pandas-dev/pandas/util/_print_versions.py", line 109, in show_versions
deps = _get_dependency_info()
File "/home/marcogorelli/pandas-dev/pandas/util/_print_versions.py", line 88, in _get_dependency_info
mod = import_optional_dependency(modname, errors="ignore")
File "/home/marcogorelli/pandas-dev/pandas/compat/_optional.py", line 142, in import_optional_dependency
module = importlib.import_module(name)
File "/home/marcogorelli/mambaforge/envs/pandas-dev/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 843, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/marcogorelli/mambaforge/envs/pandas-dev/lib/python3.8/site-packages/numba/init.py", line 42, in
from numba.np.ufunc import (vectorize, guvectorize, threading_layer,
File "/home/marcogorelli/mambaforge/envs/pandas-dev/lib/python3.8/site-packages/numba/np/ufunc/init.py", line 3, in
from numba.np.ufunc.decorators import Vectorize, GUVectorize, vectorize, guvectorize
File "/home/marcogorelli/mambaforge/envs/pandas-dev/lib/python3.8/site-packages/numba/np/ufunc/decorators.py", line 3, in
from numba.np.ufunc import _internal
SystemError: initialization of _internal failed without raising an exception

@MarcoGorelli MarcoGorelli added Bug Needs Triage Issue that has not been reviewed by a pandas team member Datetime Datetime data dtype and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 13, 2022
@MarcoGorelli MarcoGorelli changed the title BUG: warning shown when parsing delimited date string even if users can't do anything about it WARN: warning shown when parsing delimited date string even if users can't do anything about it Dec 13, 2022
@ShisuiUzumaki
Copy link
Contributor

@MarcoGorelli Do we need to remove this warning, if it is not too complex a task, I would like to try it. Could you guide me through the process of removing and testing?

@MarcoGorelli
Copy link
Member Author

I've already opened #50232, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
2 participants