-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Use stronger assertion in pandas/tests/groupby/test_allowlist.py::test_regression_allowlist_methods
#49629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this an issue that's welcoming contributions? |
Definitely @isaac-chung. Feel free to tackle it! |
Looking for ways to generate the Is this something close to the best we can do for now? Even then, this does not match
I hope to see if there is something obvious that I'm missing before I go into a rabbit hole. Also happy to discuss this or let another contributor take a go if needed. |
The apply idea is a good one - fair point though it might not conveniently support all the supported arguments. Since this test is mainly smoketest for groupby methods and args, I think it's valid to replace |
Sounds good, this would simplify things quite well. Let me share what I currently have in a pull request. |
Before #49611,
test_regression_allowlist_methods
was a comprehensive groupby test that assertedframe.groupby(...).op(...)
was equivalent toframe.op(level=..., ...)
. Now thatlevel
has been removed, this test should ideally have a stronger assertion than current testing that a DataFrame is returned; ideally usingtm.assert_frame_equal
The text was updated successfully, but these errors were encountered: