Skip to content

TST: Subclasses of ExcelWriter should not be allowed to add new public attributes #49602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Nov 9, 2022 · 1 comment · Fixed by #50097
Closed

TST: Subclasses of ExcelWriter should not be allowed to add new public attributes #49602

rhshadrach opened this issue Nov 9, 2022 · 1 comment · Fixed by #50097
Assignees
@catmar22
Labels
API - Consistency Internal Consistency of API/Behavior IO Excel read_excel, to_excel Needs Tests Unit test(s) needed to prevent regressions

Comments

@rhshadrach
Copy link
Member

rhshadrach commented Nov 9, 2022 •
edited
Loading

Ref: #48577

I think subclasses of ExcelWriter (e.g. XlsxWriter) should not be allowed to add any public attributes so that the attributes accessible by users are independent of the engine being used. This appears to currently be the case, and to ensure it remains that way, I think we should add tests for each subclass that would fail if any additional public attributes are added.
@rhshadrach rhshadrach added IO Excel read_excel, to_excel Needs Tests Unit test(s) needed to prevent regressions API - Consistency Internal Consistency of API/Behavior labels Nov 9, 2022
@rhshadrach rhshadrach mentioned this issue Nov 9, 2022
Closed
@catmar22
Copy link
Contributor

take

@rhshadrach rhshadrach changed the title TST: Subclasses of ExcelWriter should not be allowed to add new public methods TST: Subclasses of ExcelWriter should not be allowed to add new public attributes Nov 29, 2022
@catmar22 catmar22 mentioned this issue Dec 6, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catmar22 catmar22

Labels
API - Consistency Internal Consistency of API/Behavior IO Excel read_excel, to_excel Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST: added test to ensure subclasses of ExcelWriter don't add any public attributes catmar22/pandas
2 participants
@rhshadrach @catmar22