Skip to content

BUG: pandas/tests/test_algos.py::TestValueCounts::test_value_counts_normalized failing on ARM tests #49468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
MarcoGorelli opened this issue Nov 2, 2022 · 1 comment · Fixed by #49476
Closed
3 tasks done

BUG: pandas/tests/test_algos.py::TestValueCounts::test_value_counts_normalized failing on ARM tests #49468

MarcoGorelli opened this issue Nov 2, 2022 · 1 comment · Fixed by #49476
Labels
CI Continuous Integration
Milestone
2.0

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Nov 2, 2022 •
edited
Loading

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

pytest pandas/tests/test_algos.py::TestValueCounts::test_value_counts_normalized[M8[ns]]

Issue Description

See https://app.circleci.com/pipelines/github/pandas-dev/pandas?branch=main - looks like since #49361, this has been failing

Expected Behavior

cc @jbrockmendel @mroeschke does that PR look related? The test hits

pandas/pandas/core/arrays/datetimes.py

Line 2235 in 4e7ade7

data = data.astype(np.int64)

which was modified in that PR

Installed Versions

Replace this line with the output of pd.show_versions()
@MarcoGorelli MarcoGorelli added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 2, 2022
@lithomas1 lithomas1 added CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 2, 2022
@phofl phofl added this to the 2.0 milestone Nov 2, 2022
@jbrockmendel
Copy link
Member

mentioned in #49361, it is plausible that changing that line to data = data.astype("M8[ns]").view("i8") will fix the weird ARM behavior

@MarcoGorelli MarcoGorelli mentioned this issue Nov 2, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

CI maybe fix arm test MarcoGorelli/pandas
4 participants
@jbrockmendel @MarcoGorelli @lithomas1 @phofl