Skip to content

API: Series/DataFrame.mask(other) should default to lib.no_default instead of np.nan #49111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mroeschke opened this issue Oct 15, 2022 · 2 comments · Fixed by #49156
Closed

API: Series/DataFrame.mask(other) should default to lib.no_default instead of np.nan #49111

mroeschke opened this issue Oct 15, 2022 · 2 comments · Fixed by #49156
Labels
API - Consistency Internal Consistency of API/Behavior Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone
2.0

Comments

@mroeschke
Copy link
Member

mroeschke commented Oct 15, 2022 •
edited
Loading

In 1.4 (#44697), .where(other=) was changed from np.nan to lib.no_default.

Since mask is the analogous method to where, it's other argument should also default to lib.no_default
@mroeschke mroeschke added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate API - Consistency Internal Consistency of API/Behavior labels Oct 15, 2022
@rhshadrach
Copy link
Member

Just to be sure

it's other argument should also default to np.nan lib.no_default

@mroeschke
Copy link
Member Author

Just to be sure

it's other argument should also default to np.nan lib.no_default

Thanks for spotting my typo, edited my post above

@mroeschke mroeschke mentioned this issue Oct 17, 2022
Merged
5 tasks
@phofl phofl added this to the 2.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

API: Change Series/DataFrame.other default to no_default instead of np.nan mroeschke/pandas
3 participants
@mroeschke @rhshadrach @phofl