BUG/TST: Allow generators in DataFrame.from_records #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tinproject opened this issue Sep 21, 2013 · 0 comments · Fixed by #4911

Labels

API Design IO Data

Milestone

Contributor

tinproject commented Sep 21, 2013

With 0.12 and development version it's not possible fo feed a generator to Dataframe.from_records if nrows = None, it leds to a TypeError exception see: http://stackoverflow.com/questions/18915941/create-a-pandas-dataframe-from-generator

It's no clear whats nrows do, it's not documented.

I've create a PR with a simple fix without touch nrows, and two tests for generator data input.

tinproject mentioned this issue

BUG/TST: Allow generators in DataFrame.from_records #4911

Merged

jreback closed this as completed in #4911

westurner mentioned this issue

PERF: generators in dataframe.from_records #6700

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment