Skip to content

PERF: cast np.str_ to str? #48974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MarcoGorelli opened this issue Oct 6, 2022 · 2 comments
Open

PERF: cast np.str_ to str? #48974

MarcoGorelli opened this issue Oct 6, 2022 · 2 comments
Labels
Performance Memory or execution speed performance

Comments

@MarcoGorelli
Copy link
Member

xref #48970 (comment)

would it be more performant to just cast np.str_ to str? Just opening as a placeholder
@MarcoGorelli MarcoGorelli added the Performance Memory or execution speed performance label Oct 6, 2022
@MarcoGorelli MarcoGorelli mentioned this issue Oct 6, 2022
Merged
5 tasks
@phofl
Copy link
Member

phofl commented Oct 6, 2022

Possibly related to #39566

@jbrockmendel
Copy link
Member

Could also see if there is an issue in cython about recognizing numpy.str_ as a str subclass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @MarcoGorelli @phofl