Skip to content

ENH: CI check for new extras_require #48942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
JMBurley opened this issue Oct 4, 2022 · 0 comments · Fixed by #49241
Closed
1 task

ENH: CI check for new extras_require #48942

JMBurley opened this issue Oct 4, 2022 · 0 comments · Fixed by #49241
Labels
Build Library building on various platforms CI Continuous Integration

Comments

@JMBurley
Copy link
Contributor

JMBurley commented Oct 4, 2022

Feature Type

  • Adding new (test) functionality to pandas

Problem Description

CI tests should validate that the setup.cfg extras_require added for pandas 2.0.0 in #47336 are valid.

@JMBurley & @mroeschke active in that PR.

Feature Description

A CI check that pip install pandas[foo] works and install the expected dependencies for all foo in setup.cfg.

Alternative Solutions

N/A - tests are needed.

Additional Context

I don't know the current web of triggers for the GitHub Actions used to execute current CI in Pandas, but validating these builds could take well over an hour if done sequentially.

(current CI checks are not fast at ~90 min but they could get even slower with these builds!)

I'd suggest setting up parallel execution on these builds and make sure that they are triggered early in the CI process.

@JMBurley JMBurley added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 4, 2022
@mroeschke mroeschke added Build Library building on various platforms CI Continuous Integration and removed Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants