Skip to content

Generalize shift infrastructure. #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dalejung opened this issue Sep 18, 2013 · 5 comments · Fixed by #6605
Closed

Generalize shift infrastructure. #4867

dalejung opened this issue Sep 18, 2013 · 5 comments · Fixed by #6605
Labels
API Design Internals Related to non-user accessible pandas implementation
Milestone
0.14.0

Comments

@dalejung
Copy link
Contributor

Currently Panel.shift has its own code-path that is 4 years old. Change it to use the generic shift code found in generic.py/internals.py.
@dalejung
Copy link
Contributor Author

dalejung/pandas@panel-tshift-4853...general-shift-4867

@dalejung
Copy link
Contributor Author

@wesm was there a specific reason that Panel.shift dropped periods, as opposed to DataFrame.shift that kept a NaN row?

Maybe too late to change that behavior?

@wesm
Copy link
Member

wesm commented Sep 18, 2013

Was to avoid the huge allocate-copy step IIRC

@dalejung dalejung mentioned this issue Sep 18, 2013
Closed
@jreback
Copy link
Contributor

jreback commented Oct 4, 2013

@dalejung how's this coming?

@dalejung
Copy link
Contributor Author

dalejung commented Oct 5, 2013

I've been running production code on my branch with panel + general shift. Passed internal tests. Got busy while rewriting the tests. Should have time to circle back later on this week.

On Oct 4, 2013, at 4:12 PM, jreback [email protected] wrote:

@dalejung how's this coming?

—
Reply to this email directly or view it on GitHub.

@jreback jreback closed this as completed Jan 3, 2014
@jreback jreback reopened this Jan 3, 2014
@jreback jreback mentioned this issue Jan 3, 2014
Closed
@dalejung dalejung mentioned this issue Mar 22, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.14.0
3 participants
@wesm @dalejung @jreback