Skip to content

ENH: Add duplicated to MaskedArray/ExtensionArray interface #48424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
phofl opened this issue Sep 6, 2022 · 4 comments · Fixed by #55255
Closed
1 of 3 tasks

ENH: Add duplicated to MaskedArray/ExtensionArray interface #48424

phofl opened this issue Sep 6, 2022 · 4 comments · Fixed by #55255
Labels
duplicated duplicated, drop_duplicates Enhancement NA - MaskedArrays Related to pd.NA and nullable extension arrays Needs Discussion Requires discussion from core team before further action

Comments

@phofl
Copy link
Member

phofl commented Sep 6, 2022 •
edited
Loading

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

#48150 will support masks in the duplicated hashtable function. Currently, we have to special case MaskedArrays to pass the mask only when necessary into the function. This could be avoided when adding duplicated to the interface, same as unique is currently implemented

Feature Description

See above

Alternative Solutions

See above

Additional Context

No response

cc @mroeschke @jorisvandenbossche
@phofl phofl added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member Needs Discussion Requires discussion from core team before further action duplicated duplicated, drop_duplicates NA - MaskedArrays Related to pd.NA and nullable extension arrays and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 6, 2022
@phofl phofl mentioned this issue Sep 23, 2022
Closed
3 tasks
@tehunter
Copy link
Contributor

take

@phofl
Copy link
Member Author

phofl commented Sep 26, 2022

This needs some discussion first

@tehunter
Copy link
Contributor

No problem! I'm giving it a attempt on my personal fork to get more familiar with the ExtensionArray code base, but won't push through any PRs until there's a consensus on discussion items.

@tehunter tehunter removed their assignment Sep 26, 2022
@tehunter tehunter mentioned this issue Sep 26, 2022
Closed
3 tasks
@jbrockmendel
Copy link
Member

duplicate of #27264?

@jbrockmendel jbrockmendel mentioned this issue Sep 24, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicated duplicated, drop_duplicates Enhancement NA - MaskedArrays Related to pd.NA and nullable extension arrays Needs Discussion Requires discussion from core team before further action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH/PERF: add ExtensionArray.duplicated lukemanley/pandas
3 participants
@tehunter @jbrockmendel @phofl